Dmitry,

On 8/7/15 2:31 AM, Dmitry Samersoff wrote:
Serguei,
   Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be
removed?
Yes. See

https://bugs.openjdk.java.net/browse/JDK-8041639

Thank you for the comment.
But, please, see also the related comment from Staffan.

Thanks,
Serguei


-Dmitry

On 2015-08-07 12:24, serguei.spit...@oracle.com wrote:
Hi Staffan,

Looks good.

I'm re-posting the same question in this review:
   Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be
removed?

Thanks,
Serguei


On 8/6/15 11:57 PM, Staffan Larsen wrote:
Please review the following changes to remove the hprof JVMTI agent.
There are changes in three different repositories. All tests that
used the hprof agent has been removed in previous changesets.

Note: This does not remove the ability of the Hotspot VM to output
heap dumps in the hprof format.

bug: https://bugs.openjdk.java.net/browse/JDK-8046661

top-level changes:
http://cr.openjdk.java.net/~sla/8076470/root/webrev.00/
<http://cr.openjdk.java.net/%7Esla/8076470/root/webrev.00/>
jdk changes: http://cr.openjdk.java.net/~sla/8076470/jdk/webrev.00/
<http://cr.openjdk.java.net/%7Esla/8076470/jdk/webrev.00/>
hotspot changes:
http://cr.openjdk.java.net/~sla/8076470/hotspot/webrev.00/
<http://cr.openjdk.java.net/%7Esla/8076470/hotspot/webrev.00/>

Thanks,
/Staffan





Reply via email to