On 2015-09-25 17:55, timo.kinnu...@gmail.com wrote:
Hi,
I’ve been going over the Windows build of the whole JDK for a while with VS
2015 and now I have patches that allow the build to complete.
I’ve made changes in the root repository as well as in hotspot and jdk
repositories. The changes fall broadly in three categories: enabling the v140
toolchain and improving freetype compilation, adding casts to where pointers
are truncated and miscellaneous small-scale code changes.
The patch to the root repository streamlines handling of freetype by
implementing a default source directory at $HOME/freetype under Cygwin. It is
checked during configure and used for compiling if “--with-freetype-src” is not
specified. A help message giving the unpacking command with the correct
directory is also included. This patch is about 90 lines without counting
generated-configure.sh changes.
The patches to jdk and hotspot contain native code changes only and no changes
to make-files. These are about 580 and 290 lines, respectively. All patches are
generated with “hg diff -g”.
Would you be willing to incorporate these? How should I proceed with this?
Hi Timo,
First of all, I apologize that you have not recieved any response for
far too long. :-(
Thank you for your interest in helping to improve OpenJDK!
In general, a patch to allow compilation on VS 2015 Community edition
sounds like a good edition to OpenJDK. I am willing to sponsor this
patch and help you work with getting it accepted.
My first question to you is: have you signed the OCA? Also, unless
you've done so already, reading http://openjdk.java.net/contribute/ is a
good start for starting to contribute to OpenJDK.
However, supporting a new compiler, without at the same time breaking an
older one, can sometimes be tricky business. This means that you might
need to iterate your patch a number of times, until it's suitable for
inclusion. I don't want to scare you away, just be realistic up front
that it might require some more work from your part (and our!). Also,
(FYI, we have recently upgraded the compilers used at Oracle to VS2013
SP4, so I know what I'm talking about...)
From what you write, I think you should try to separate the
freetype-src default directory from the compiler upgrade settings. The
former might be easier to start with, as it's less likely to be
disruptive for anything else.
Also, at this point, I think it would be helpful for me to be able to
have an initial look at the patches. You need to be an OpenJDK Author to
be able to access the OpenJDK infrastructure, so unfortunately that is
not available to you. :-( For a first peek, the patches can be provided
just about any way (but attachments to this list is unfortunately not
allowed). For a final, proper, code review they need to reside on our
infrastructure, but at that point I can help with fixing that.
/Magnus
