The fix looks good. I'm just wondering if there are any other problematic characters that needs to be escaped, such as \. Or should we address such issues when they arise?
/Magnus > 26 okt. 2015 kl. 11:55 skrev Erik Joelsson <[email protected]>: > > When I optimized the vardeps functionality in JDK-8136385, I caused a > regression when the variable contained '$' characters. By reading the old > value as a makefile using "include", variable substitution is applied. To > work around this, dollar characters need to be escaped (doubled) prior to > printing the variable value to the vardeps makefile. > > This causes native libraries to be relinked every time they are incrementally > built because of the "\$ORIGIN" string. > > Also updating tests to cover this. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8140484 > Webrev: http://cr.openjdk.java.net/~erikj/8140484/webrev.01/ > > /Erik
