On 2015-10-28 15:29, Erik Joelsson wrote:
On 2015-10-28 14:56, Magnus Ihse Bursie wrote:
On 2015-10-28 11:14, Erik Joelsson wrote:
In Jake, when crosscompiling, we need to build a subset of the jdk,
including hotspot, to be able to run jmod and jlink. Currently, the
build compiler is just found on the system so such a configuration
requires the build system to basically be able to compile the jdk
without a devkit. The idea with devkits was partly to avoid this.
The solution would be to add another configure parameter that
defines a devkit for the build compiler.
Bug: https://bugs.openjdk.java.net/browse/JDK-8140593
Webrev: http://cr.openjdk.java.net/~erikj/8140593/webrev.01/
I'm getting slightly confused on how devkits really propagate their
information to configure. I think we're kind of missing a piece here,
we're giving configure clues on where to look but we still to not
explicitely point to e.g. the complete (relative) compiler binary
path in the devkit. Otoh, that's not really part of your fix and if
it works, I'm okay with it.
That communication could perhaps be improved yes.
One nitpick:
+ $SED -e "s/^DEVKIT_/BUILD_DEVKIT_/g" \
+ -e "s/\$DEVKIT_ROOT/\$BUILD_DEVKIT_ROOT/g" \
I believe the last line here is unnecessary.
Not so imo. The first one only matches beginning of a line for
replacing assignments. The second matches variable references to
DEVKIT_ROOT. It's likely unnecessary to be this specific though so I
could do a simple "s/DEVKIT_/BUILD_DEVKIT_/g" to cover both cases.
I missed the ^, sorry. You're right, they are different and more
specific. Keep them that way.
/Magnus
