Looks okay to me. Where do you propose to push this? Please submit via JPRT.
Thanks. David On 6/11/2015 2:18 AM, Magnus Ihse Bursie wrote:
Currently the /WX flag is hardcoded in the Hotspot windows make files. This makes it impossible to turn of warnings-as-errors for Windows without explicitely hacking the makefiles. This should be fixed. Bug: https://bugs.openjdk.java.net/browse/JDK-8141548 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8141548-hotspot-windows-build-should-respect-warnings-as-errors/webrev.01 /Magnus