On Fri, Nov 6, 2015 at 10:35 AM, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> wrote: > On 2015-11-05 18:19, Volker Simonis wrote: >> >> Hi Magnus, >> >> great that finally somebody is addressing this issue! >> >> But shouldn't we also change the lines: >> >> WARNINGS_ARE_ERRORS = -Werror >> >> to: >> >> WARNINGS_ARE_ERRORS ?= -Werror >> >> in the various hotspot compiler files (e.g. >> make/linux/makefiles/gcc.make). > > Hm..? I've just been following an old "recipe" to set WARNINGS_ARE_ERRORS to > empty for disabling Hotspot builds. I tested on my local machine that it did > indeed allow warnings to pass, and then I was happy, and didn't look into > the Hotspot makefiles. > > I agree that this does look a bit weird, but I think it works since make let > command line variables override even what's explicitely set in the > makefiles. I don't think it's worth fixing in the old hotspot build. >
If it's set on the command line, you're right. But I couldn't find the place where it is set on the command line. As far as I saw, it is only passed through hotspot-spec.gmk. Could you please point me to the place, where WARNINGS_ARE_ERRORS is passed to make as a command line parameter? Maybe I'm a little confused, but I don't see it ... > /Magnus > > >> >> Maybe I'm missing something, or do you plan to do that as a follow up >> change in the hotspot repo? >> >> Otherwise looks good. >> >> Thank you and best regards, >> Volker >> >> >> On Thu, Nov 5, 2015 at 4:43 PM, Magnus Ihse Bursie >> <magnus.ihse.bur...@oracle.com> wrote: >>> >>> Unfortunately, the --disable-warnings-as-errors flag only operates on the >>> build-infra code, and does not propagate to the Hotspot build system. >>> >>> This is unfortunate, and also very confusing for users who think they >>> have >>> disabled warnings as errors, only to get an error in the hotspot build >>> instead. >>> >>> We should set the correct value for hotspot makefiles from configure as >>> well. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8141543 >>> WebRev: >>> >>> http://cr.openjdk.java.net/~ihse/JDK-8141543-propagate-disable-warnings-as-errors-to-hotspot/webrev.01 >>> >>> /Magnus > >
