Hi Erik, > One thing, could you name the variable DEBUG_SYMBOLS, with the S at the > end so that it matches the configure option?
Currently, ENABLE_DEBUG_SYMBOLS (--enable-debug-symbols) is available. So I add DEBUG_SYMBOL to avoided confuse. I think that it is very trivial change... Thanks, Yasumasa On 2015/11/16 18:55, Erik Joelsson wrote: > Hello, > > I think this looks mostly OK, but I'm pretty sure Magnus will want to > comment. I'm afraid he likely won't be able to until next week however. > > One thing, could you name the variable DEBUG_SYMBOLS, with the S at the > end so that it matches the configure option? > > /Erik > > On 2015-11-16 10:38, Yasumasa Suenaga wrote: >> Hi all, >> >> I would like to propose JDK-8036003: Add >> --with-debug-symbols=[none|internal|external|zipped] . >> >> I had posted this enhancement which provides new make variable [1]. >> But it does not fit current jdk 9. So I propose it again as new configure >> option. >> >> I'm sure that this enhancement helps Linux distros to package OpenJDK. >> For example, if you create RPM package of OpenJDK, you have to pass many >> make variables [2]. >> >> Could you review it? >> http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.00/ >> >> >> Thanks, >> >> Yasumasa >> >> >> [1] >> http://mail.openjdk.java.net/pipermail/build-dev/2014-February/012019.html >> [2] >> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2015-November/034036.html >> >
