Mandy, On 25.11.2015 18:22, Mandy Chung wrote:
On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik <[email protected]> wrote: Updated webrevs: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdkThis looks fine to me. Is there any test referencing the packages in jdk.jvmstat.rmi? I only found @modules with "jdk.jvmstat/sun.jvmstat.monitor” "jdk.jvmstat/sun.jvmstat.montior.event” It’d be good to double check and adjust the module name if any.
The only place jstatd (the only usage of the RMI MonitoredHost provider) is exercised is in jdk/test/sun/tools/jstatd - and it is all done via executing jstatd as an external process so it doesn't require putting jdk.jvmstat.rmi in @modules, IMO.
-JB-
Mandy
