Hi Volker, I had a look at your changes. Good that 'warning as errors' already lead to a fix :)
Note that your changes might break the old build, as you remove the endianess check in flags.m4 etc.. I think this is ok, though, as else dead code will remain in the file. Looks good, reviewed. Best regards, Goetz. > -----Original Message----- > From: hotspot-dev [mailto:hotspot-dev-boun...@openjdk.java.net] On > Behalf Of Erik Joelsson > Sent: Dienstag, 12. April 2016 18:18 > To: Volker Simonis <volker.simo...@gmail.com>; HotSpot Open Source > Developers <hotspot-...@openjdk.java.net>; build-dev <build- > d...@openjdk.java.net> > Subject: Re: RFR(S): 8154087: Fix AIX and Linux/ppc64le after the integration > of the new hotspot build > > Hello Volker, > > This looks good to me. I will sponsor the change into hs-rt once someone > reviews the source code changes. > > /Erik > > On 2016-04-12 18:03, Volker Simonis wrote: > > Hi, > > > > can I please have a review for the following trivial changes to make > > the build work again on AIX and Linux/ppc64le after the integration of > > the new hotspot build system. The changes are all AIX and/or ppc64 > > specific and shouldn't change the behavior on any other platform. > > > > Because the top-level changes require the rebuild of > > generated-configure.sh and the hotspot changes are in shared code, I > > also need a sponsor. It would be best if the changes could be pushed > > in sync to the hs-rt repository: > > > > http://cr.openjdk.java.net/~simonis/webrevs/2016/8154087.top > > http://cr.openjdk.java.net/~simonis/webrevs/2016/8154087.hs > > http://cr.openjdk.java.net/~simonis/webrevs/2016/8154087.jdk > > > > https://bugs.openjdk.java.net/browse/JDK-8154087 > > > > The hotspot change contains a trivial source code change in an AIX > > file to fix a warning which would otherwise break the build with > > "warnings as errors". > > > > The jdk change disables "warnings as errors" for AIX for several libs > > such that we can build the complete jdk with "warnings as errors" on > > AIX as well now. Fixing the actual warnings will be done in a later > > change. > > > > Thanks a lot and best regards, > > Volker
