Dear All
Please find updated webrev for this fix here:
http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/hotspot/
<http://cr.openjdk.java.net/%7Elmesnik/8154209/webrev.00/hotspot/>
http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/root/
The client jvm is removed from linux-x86 and windows-x86 profiles. The
linux-x86 currently includes minimal and server VM. The server VM is
used by default.
The test targets has been updated to test server for this profiles.
Leonid
On 21.04.2016 09:23, Leonid Mesnik wrote:
Mikael
On 21.04.2016 00:41, Mikael Vidstedt wrote:
Good catch. Updated webrevs here:
top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/common/conf/jib-profiles.js.udiff.html
<http://cr.openjdk.java.net/%7Emikael/webrevs/8154209/webrev.02/webrev/common/conf/jib-profiles.js.udiff.html>
Couldn't be
*"--with-jvm-variants=client,server"*
just completely removed now as for all 64bit profiles?
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/make/jprt.properties.sdiff.html
<http://cr.openjdk.java.net/%7Emikael/webrevs/8154209/webrev.02/webrev/make/jprt.properties.sdiff.html>
213 windows_i586_6.3-product-c1-TESTNAME, \
I see that you just remove C1 testing. Wouldn't be better to replace
it with c2? (Same for line 298)
Leonid
hotspot:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/hotspot/webrev/
Incremental webrevs (from webrev.01):
top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02.incr/webrev/
hotspot: N/A (same as webrev.01)
Cheers,
Mikael
On 4/18/2016 12:52 AM, Leonid Mesnik wrote:
Hi
Shouldn't be jprt targets in jprt.properties updates to stop using
client also?
http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties
line 206 - 214
# Test target list (no fastdebug & limited c2 testing)
my.test.target.set= \
solaris_sparcv9_5.11-product-c2-TESTNAME, \
solaris_x64_5.11-product-c2-TESTNAME, \
linux_i586_3.8-product-{c1|c2}-TESTNAME, \
linux_x64_3.8-product-c2-TESTNAME, \
macosx_x64_10.9-product-c2-TESTNAME, \
windows_i586_6.3-product-c1-TESTNAME, \
windows_x64_6.3-product-c2-TESTNAME
and
line 294-299
# JCK test targets in test/Makefile (no windows)
my.test.target.set.jck= \
solaris_sparcv9_5.11-product-c2-JCK7TESTRULE, \
solaris_x64_5.11-product-c2-JCK7TESTRULE, \
linux_i586_3.8-product-c1-JCK7TESTRULE, \
linux_x64_3.8-product-c2-JCK7TESTRULE
Leonid
On 14.04.2016 19:41, Mikael Vidstedt wrote:
Please review the following change which removes the "client" VM
from the default JIB build profile on windows-x86 and linux-x86:
Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/
When not including the client VM, the build system automatically
creates a jvm.cfg which makes -client an alias for -server. At some
point in the future we may choose to output a warning and/or refuse
to start up if -client is specified, but at least for now silently
falling back on the -server VM seems appropriate.
The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test
assumes that CDS is always compiled in and enabled in the -client
VM on windows-x86. Since -client will fall back on -server that is
no longer true, so the test needs to be updated. I added an @ignore
and filed the following issue to track fixing the test:
https://bugs.openjdk.java.net/browse/JDK-8154204
Testing:
In addition to a standard JPRT push job, Christian Tornqvist helped
me run the runtime nightly tests and apart from the above mentioned
test all tests were successful.
Cheers,
Mikael
