snip...
> >> > >> What I'm worried about is that by keeping those checks we might get > >> and use the wrong answer in some cases where the BUILD and TARGET > >> compilers are of different vintage. Maybe that will just encourage > >> someone to fix them... > > > > Thanks. I agree it's an issue. I just don't think I'm the right person > > to undertake rewiring all that, as I've never even used the > > cross-compilation > > support so far. > > Yeah, I feel the same way. While I've dealt with cross-compilation > issues of this sort enough to recognize the presence of problems, that > work wasn't with this build system. > > > Do you know if there's already a bug for this? If not, I'll file one. > > I didn't find any relevant bugs. > I've filed one: https://bugs.openjdk.java.net/browse/JDK-8160926 snip... > > > Revised webrevs: > > > > http://cr.openjdk.java.net/~andrew/8156980/webrev.04/root > > http://cr.openjdk.java.net/~andrew/8156980/webrev.04/hotspot > > These look good to me. > Thanks. I need someone at Oracle to push this one through, as the configure script for the closed code needs regenerating too. Apparently, I broke things last time :( > > I'm also now seeing a problem with GCC 6 only that is unique to the latest > > OpenJDK 9 > > and what looks like the gtest code. It seems to be the result of the header > > changes > > also documented in [0] which were introduced in January [1] (and so > > probably weren't > > in earlier test versions of GCC 6). I'm able to work around it and get a > > completed > > build by setting -D_GLIBCXX_INCLUDE_NEXT_C_HEADERS, so it seems to be > > something > > to do with the changes to stdlib.h in GCC 6. Something for a separate bug. > > What fun! A new batch of changes just came through which seems to have fixed it. I'm guessing this one: http://hg.openjdk.java.net/jdk9/dev/hotspot/rev/7862a718ec47 Either way, I'm happy I don't have to debug it :-) > > > [0] https://gcc.gnu.org/gcc-6/porting_to.html > > [1] > > https://github.com/gcc-mirror/gcc/commit/6c8ced3f4f867b72a623fe2f23efa204c5786a28 > > -- > > Andrew :) > > > > Senior Free Java Software Engineer > > Red Hat, Inc. (http://www.redhat.com) > > > > PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) > > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > > Thanks for the great feedback on this patch, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
