On 7/19/16 11:19 AM, Alan Burlison wrote:
This removes redundant/incorrect compilation flags from the Solaris build environment.

https://bugs.openjdk.java.net/browse/JDK-8161057
http://cr.openjdk.java.net/~dcubed/for_alanbur/8161057-webrev/0-jdk9-hs-all/

I already have one commend from DanD:

jdk/src/demo/share/jvmti/java_crw_demo/sample.makefile.txt
    Copyright year updated to '2015' instead of '2016'.

I've already fixed that in my workspace but it's still present in the above webrev.

common/autoconf/flags.m4
    No comments.

common/autoconf/generated-configure.sh
    No comments.

jdk/src/demo/share/jvmti/compiledMethodLoad/sample.makefile.txt
    No comments.

jdk/src/demo/share/jvmti/gctest/sample.makefile.txt
    No comments.

jdk/src/demo/share/jvmti/heapTracker/sample.makefile.txt
    No comments.

jdk/src/demo/share/jvmti/heapViewer/sample.makefile.txt
    No comments.

jdk/src/demo/share/jvmti/java_crw_demo/sample.makefile.txt
    No additional comments.

jdk/src/demo/share/jvmti/minst/sample.makefile.txt
    No comments.

jdk/src/demo/share/jvmti/mtrace/sample.makefile.txt
    No comments.

jdk/src/demo/share/jvmti/versionCheck/sample.makefile.txt
    No comments.

Thumbs up.

Dan



There were some JPRT test failures on OSX and Windows, as this changeset doesn't affect those platforms I believe they can be ignored.

There is some related cleanup in deploy, that will be covered by https://bugs.openjdk.java.net/browse/JDK-8161081, by removing the Solaris-related scripts.


Reply via email to