On 07/21/16 05:34, Alan Burlison wrote:
On 21/07/2016 01:40, Tim Bell wrote:

Looks good to me.

It is already common practice for the build to set:

   LC_ALL=C
   export LC_ALL

Note that this doesn't seem to be happening for the tests run by 'make test', at least not on Solaris. The result is a bunch of date/time formatting test failures. Manually setting LC_CTYPE=C before running 'make tests' fixes the problem.

True. This situation could be improved. I found "LC_ALL=C; export LC_ALL" (or the equivalent) spread liberally throughout Makefiles and scripts. The only documentation I found mentioning locale was in a netbeans make README, which is buried pretty far down:

http://hg.openjdk.java.net/jdk9/dev/jdk/file/tip/make/netbeans/README

It's on my list to fix...

Good, thanks.

Tim

Reply via email to