Thanks for reviews everyone!
On 2016-08-09 03:00, David Holmes wrote:
Hi Erik,
On 9/08/2016 2:04 AM, Erik Joelsson wrote:
Hello,
The hotspot native libraries on macosx are currently being packaged as
"universal binaries" (while all other libraries and executables are
not). There seems to be no point in doing so since we only build for one
architecture anyway. I believe this is just something that was never
cleaned up a long time ago and has just been around since. In the new
hotspot build, we duplicated the behavior with the intention of removing
it later. That time has now come.
I have verified that a hotspot job for macosx still works.
Bug: https://bugs.openjdk.java.net/browse/JDK-8069540
Webrev: http://cr.openjdk.java.net/~erikj/8069540/webrev.01/
Am I missing something:
MACOSX_UNIVERSAL=@MACOSX_UNIVERSAL@
there does not seem to be anything ever setting the substitution
variable ??
Is the LIPO variable/tool used any more?
It's still used in one case in an Oracle internal build step. I could
move the check for lipo to closed configure, but doesn't seem worth it
to me. The tool is always available on macosx if there is a compiler
environment.
/Erik
Otherwise removal looks fine.
Thanks,
David
/Erik
