Looks good. Mandy
> On Sep 13, 2016, at 2:41 AM, Sundararajan Athijegannathan > <sundararajan.athijegannat...@oracle.com> wrote: > > Modified existing test to check quotes around properties added by jlink: > > Updated webrevs: > > jdk: > > http://cr.openjdk.java.net/~sundar/8163320/jdk/webrev.02/ > > Top: > > http://cr.openjdk.java.net/~sundar/8163320/top/webrev.02/ > > Thanks > > -Sundar > > > On 9/9/2016 9:07 PM, Mandy Chung wrote: >> Looks good. >> >> Is there an existing test to check the content of `release` file? It would >> be good to have a test to sanity test a few properties and its quoted value. >> >> Mandy >> >>> On Sep 9, 2016, at 6:02 AM, Sundararajan Athijegannathan >>> <sundararajan.athijegannat...@oracle.com> wrote: >>> >>> Please review fix for https://bugs.openjdk.java.net/browse/JDK-8163320 >>> >>> jdk repo: >>> >>> http://cr.openjdk.java.net/~sundar/8163320/jdk/ >>> >>> * JAVA_VERSION is derived from module-info of java.base >>> >>> * adding quotes around all 'release' properties >>> >>> top repo: >>> >>> http://cr.openjdk.java.net/~sundar/8163320/top/webrev.01/ >>> >>> Makefile changes to avoid generating OS_NAME, JAVA_VERSION etc. - as >>> jlink takes care of those. >>> >>> Thanks >>> >>> -Sundar >>> >
