On 2016-10-04 11:30, Erik Joelsson wrote:
That was intended but I discovered that the whole thing was wrong. The
default strip flag we use on Linux "-g" and the new flag we set for
minimal "--strip-unneeded" are the mutually exclusive, so whatever
ends up last on the command line wins. Since the new flag is an
override, we should treat it as such in the makefile logic as well.
Also, the proposed change would have cleared the STRIPFLAGS parameter
for all other platforms and configurations, because the STRIPFLAGS
parameter to SetupNativeCompilation accepts an empty value as an
override. Because of this, we need to give JVM_STRIPFLAGS a default
value.
New webrev: http://cr.openjdk.java.net/~erikj/8164120/webrev.hotspot.02/
Looks good to me!
/Magnus
Properly verified that the minimal JVM is now smaller and that there
is no difference when building other JVMs.
/Erik
On 2016-10-04 09:32, Magnus Ihse Bursie wrote:
On 2016-10-03 15:52, Erik Joelsson wrote:
Hello,
Please review this small change, which adds --strip-unneeded when
stripping the minimal VM on Linux, which reduces size on x86 builds
with around 1.2MB.
Bug: https://bugs.openjdk.java.net/browse/JDK-8164120
Webrev: http://cr.openjdk.java.net/~erikj/8164120/webrev.hotspot.01/
/Erik
Looks good to me. Just a style question: any particular reason you're
not using
JVM_STRIPFLAGS += --strip-unneeded
?
/Magnus
