On 2016-10-15 03:23, Tim Bell wrote:
Please review this rework of the langtools/test/Makefile fix done in 8166648. [1] ARCH_DATA_MODEL is not set in all test scenarios, so a better approach is to check the VM about to be tested.


Bug report:
    https://bugs.openjdk.java.net/browse/JDK-8167600

Webrev:
    http://cr.openjdk.java.net/~tbell/8167600/webrev.00/

Testing:
Successful JPRT runs on all platforms. Inspected the <platform>_<arch>.product-c2-langtools_jtreg.log files to verify the expected flag was used only on 32-bit VMs.

Hi Tim,

Seems a bit complicated to create a temporary javascript and execute it. Why not try something like: DATA_MODEL=`${JT_JAVA}/bin/java -XshowSettings:properties -version 2>&1 | grep sun.arch.data.model | awk '{print $3}'`
?


Thanks in advance-

Tim

[1] JDK-8166648 https://bugs.openjdk.java.net/browse/JDK-8166648

Reply via email to