Please review these fairly trivial patches for:
https://bugs.openjdk.java.net/browse/JDK-8167187

It was decided that since getWindow is deprecated and likely to be removed in a 
future release that it's not worth changing the signature which would 
potentially break other uses of jdk.jsobject in the future. Instead we'll just 
suppress the warning for that method only and remove the -Xlint:-exports flag.


top level patch:

diff --git a/make/CompileJavaModules.gmk b/make/CompileJavaModules.gmk
--- a/make/CompileJavaModules.gmk
+++ b/make/CompileJavaModules.gmk
@@ -436,10 +436,6 @@
 
 
################################################################################
 
-jdk.jsobject_ADD_JAVAC_FLAGS := -Xlint:-exports
-
-################################################################################
-
 jdk.dev_CLEAN_FILES := $(wildcard \
     $(patsubst %, $(JDK_TOPDIR)/src/jdk.dev/share/classes/%/*.properties, \
         com/sun/tools/script/shell))



jdk patch:

diff --git a/src/jdk.jsobject/share/classes/netscape/javascript/JSObject.java 
b/src/jdk.jsobject/share/classes/netscape/javascript/JSObject.java
--- a/src/jdk.jsobject/share/classes/netscape/javascript/JSObject.java
+++ b/src/jdk.jsobject/share/classes/netscape/javascript/JSObject.java
@@ -156,6 +156,7 @@
      */
 
     @Deprecated(since = "9")
+    @SuppressWarnings("exports")
     public static JSObject getWindow(Applet applet) throws JSException {
         return ProviderLoader.callGetWindow(applet);
     }


-DrD-

Reply via email to