On 10/31/16 11:38 AM, Phil Race wrote: > +1. > > I am assuming you made sure AccessBridgeCalls.c is not being compiled > during the JDK build as discussed earlier ... I looked into this. The obj is needed to build accessbridgeinspector/walker. Searching the built directories AccessBridgeCalls.* is only found as an obj file in support directory:
$ find . -name AccessBridgeCalls.obj ./windows-x86-normal-server-release/support/native/jdk.accessibility/jaccessinspector/AccessBridgeCalls.obj ./windows-x86-normal-server-release/support/native/jdk.accessibility/jaccessinspector-32/AccessBridgeCalls.obj ./windows-x86-normal-server-release/support/native/jdk.accessibility/jaccesswalker/AccessBridgeCalls.obj ./windows-x86-normal-server-release/support/native/jdk.accessibility/jaccesswalker-32/AccessBridgeCalls.obj ./windows-x86_64-normal-server-release/support/native/jdk.accessibility/jaccessinspector/AccessBridgeCalls.obj ./windows-x86_64-normal-server-release/support/native/jdk.accessibility/jaccesswalker/AccessBridgeCalls.obj I searched for AccessBrdigeCalls.* too but it only turns up the source files and intermediate build files, no binaries other than the above. Erik, I need your +1 again because the make files have changed since you last looked. I'll also be running JPRT before I push. Pete > > -phil. > > On 10/31/2016 07:36 AM, Pete Brunet wrote: >> >> On 10/28/16 8:14 PM, Mandy Chung wrote: >>>> On Oct 28, 2016, at 1:59 PM, Philip Race <philip.r...@oracle.com> >>>> wrote: >>>> >>>> If it is not in the image then there is no point in the file existing. >>>> Maybe this could just be a comment at the top of the include file. >>>> >>> This works for me. >> Updated: >> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.09/ >>> Mandy >>> >>>> -phil. >>>> >>>> On 10/28/16, 12:42 PM, Mandy Chung wrote: >>>>>> On Oct 28, 2016, at 11:32 AM, Pete >>>>>> Brunet<peter.bru...@oracle.com> wrote: >>>>>> >>>>>> Hi Mandy, That simplifies things. The new patch is at: >>>>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.08/ >>>>> Looks better. >>>>> >>>>> I only notice now that the readme.html is in the include >>>>> directory. That should be in the documentation as you proposed >>>>> earlier. I don’t think it should be copied to the image. >>>>> >>>>> Mandy >>>>> >
