I would recommend using the -q flag to grep instead of piping to
/dev/null. Otherwise I think this looks ok.
/Erik
On 2016-12-16 14:45, Staffan Larsen wrote:
The failure handler (test/failure_handler) runs a number of commands when it detects a timeout in
one of the tests. On OS X some of these commands require "Developer mode" (like getting a
core file). If "Developer mode" is not enabled, the tools will open a modal dialog. This
is problematic when running automated test. The dialog will also prevent other tests from
completing.
This patch changes the Failure handler to check if "Developer mode" is enabled
before running commands that require it. It also includes the output of "DevToolsSecurity
—status” which is used to check for “Developer mode”.
Please review the webrev below,
/Staffan
bug: https://bugs.openjdk.java.net/browse/JDK-8171366
webrev: http://cr.openjdk.java.net/~sla/8171366/webrev.00/
