Thanks, looks good.
/Erik
On 2016-12-26 16:06, Sergey Bylokhov wrote:
If there are no objections I’ll push this version:
http://cr.openjdk.java.net/~serb/8140266/webrev.01/make/lib/Awt2dLibraries.gmk.sdiff.html
<http://cr.openjdk.java.net/%7Eserb/8140266/webrev.01/make/lib/Awt2dLibraries.gmk.sdiff.html>
Build change looks ok, but I too think a comment explaining why is a
good idea.
/Erik
On 2016-12-23 15:49, Philip Race wrote:
Looks OK to me although it is a very cryptic option so maybe include
a comment
that it is for performance with some versions of gcc ...
-phil.
On 12/23/16, 3:15 AM, Sergey Bylokhov wrote:
Hello.
Please review the small fix for jdk9.
The change add an additional gcc option to the libawt lib to
improve some graphics operations: 20%.
This option is a part of -03.
|-fgcse-after-reload|
When -fgcse-after-reload is enabled, a redundant load elimination
pass is performed after reload. The purpose of this pass is to
clean up redundant spilling.
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html
Note that if -03 will be enabled directly via OPTIMIZATION flag
then the performance will not be improved.
Bug: https://bugs.openjdk.java.net/browse/JDK-8140266
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8140266/webrev.00