On 2017-01-12 15:11, Erik Joelsson wrote:
Looks good. Are you sure MAKE_ARGS should be added to bootcycle-images? I assume you have tested this.

You think too highly of me. ;-)

I had in fact not tested the bootcycle-image step. Now I have, and it does work. I beleive it's good to have it, so additional make flags will get passed to the second stage of the bootcycle build. If not, it's probably not a big loss, but I think it's better to have it.

/Magnus


/Erik


On 2017-01-12 14:47, Magnus Ihse Bursie wrote:
In JDK-8170284, the hotspot build logic was better integrated with the top make level. However, the calls to make there was not provided with MAKE_ARGS.

Bug: https://bugs.openjdk.java.net/browse/JDK-8170863
WebRev: http://cr.openjdk.java.net/~ihse/JDK-8170863-always-pass-MAKE_ARGS/webrev.01

/Magnus



Reply via email to