Hi Joe,

Changes look okay. So does javac already handle arbitrary source/target values?

We need the usual set of "new release" updates to change JDK version as well. Where does that hide these days ??

And do we also need to update the boot JDK to be JDK 9?

What else is needed for a new release to start? We really should have all this captured in a single bug report.

Also wondering if JPRT will need any updates ...

Thanks,
David


On 26/01/2017 12:03 PM, Joseph D. Darcy wrote:
Hello,

With the opening of the JDK 10 forests, the build should be updated to
use the new source and target options (JDK-8028546:
Add -source 10 and -target 10 to javac)

Please review the changes for

    JDK-8173383: Update JDK build to use -source and -target 10
    http://cr.openjdk.java.net/~darcy/8173383.0/

Patch below.

Thanks,

-Joe

--- old/make/common/SetupJavaCompilers.gmk    2017-01-25
18:02:28.935118958 -0800
+++ new/make/common/SetupJavaCompilers.gmk    2017-01-25
18:02:28.843118954 -0800
@@ -69,7 +69,7 @@
 $(eval $(call SetupJavaCompiler,GENERATE_JDKBYTECODE, \
     JVM := $(JAVA_JAVAC), \
     JAVAC := $(NEW_JAVAC), \
-    FLAGS := -source 9 -target 9 \
+    FLAGS := -source 10 -target 10 \
         -encoding ascii -XDignore.symbol.file=true $(JAVAC_WARNINGS), \
     SERVER_DIR := $(SJAVAC_SERVER_DIR), \
     SERVER_JVM := $(SJAVAC_SERVER_JAVA)))
@@ -79,7 +79,7 @@
 $(eval $(call SetupJavaCompiler,GENERATE_JDKBYTECODE_NOWARNINGS, \
     JVM := $(JAVA_JAVAC), \
     JAVAC := $(NEW_JAVAC), \
-    FLAGS := -source 9 -target 9 \
+    FLAGS := -source 10 -target 10 \
         -encoding ascii -XDignore.symbol.file=true $(DISABLE_WARNINGS), \
     SERVER_DIR := $(SJAVAC_SERVER_DIR), \
     SERVER_JVM := $(SJAVAC_SERVER_JAVA)))

Reply via email to