Hi Magnus,

On 3/02/2017 11:14 PM, Magnus Ihse Bursie wrote:
Currently there are three different ways of expressing a boolean value
in spec.gmk, true/false, yes/no and 1/0. We should only have one and
since true/false is the most common one, we should stick to that.

Since this bug was opened, most cases has been fixed but two remains:
USE_PRECOMPILED_HEADER=1

One nit:

hotspot/src/share/vm/precompiled/precompiled.hpp

I don't think we normally document configure args in the source code, and I would expect that we can still pass USE_PRECOMPILED_HEADERS=true/false as a make arg. So I think this should also just change 0 to false.

Thanks,
David

ENABLE_INTREE_EC=yes

Bug: https://bugs.openjdk.java.net/browse/JDK-8004842
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8004842-standardize-booleans-in-build/webrev.01


/Magnus

Reply via email to