> On Feb 8, 2017, at 3:39 AM, Alan Bateman <[email protected]> wrote: > > On 08/02/2017 11:33, Erik Joelsson wrote: > >> When building java.base.jmod, we use --hash-modules to include hashes of all >> the non upgradeable jmods in java.base.jmod. The make dependencies are setup >> to make sure all non upgradeable jmods are built before java.base.jmod. In >> some cases, this risks failing because we have a non upgradeable module >> which depends on an upgradeable module. If this upgradeable module is not >> available to the jmod tool, it will fail. >> >> The solution is to add all jmods as prerequisites to building java.base.jmod >> instead of just the non upgradeable ones. > This looks okay although ideally we should not have non upgradeable modules > depending on upgradeable modules. >
The change looks fine to me. This is an odd case that FX module depending on an upgradeable module. One option is to make such FX module upgradeable but that seems to be less preferred. We will revisit this in JDK 10. Mandy
