Just to note here, this means an external version of Graal will now have to use 
--add-exports VM options to access JVMCI. Which is ok since additional VM 
options are required anyway to put an external Graal on the module path.

-Doug

> On 16 Feb 2017, at 08:54, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> 
> wrote:
> 
> On 2017-02-16 02:37, Vladimir Kozlov wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8174879 
>> 
>> jdk.vm.ci and jdk.vm.compiler are purely JVM internal modules that is only 
>> of interest to VM developers (and researchers), not general Java developers. 
>> It'd be appropriate for it to be an internal module and not to export any 
>> API. 
>> 
>> Rename jdk.vm.ci and jdk.vm.compiler modules to jdk.internal.vm.ci and 
>> jdk.internal.vm.compiler. No packages renaming. 
>> Exports jdk.vm.ci.services only to jdk.internal.vm.compiler. 
>> 
>> Webrevs: 
>> 
>> top: http://cr.openjdk.java.net/~kvn/8174879/webrev.top/ 
>> jdk: http://cr.openjdk.java.net/~kvn/8174879/webrev.jdk/ 
>> hotspot: http://cr.openjdk.java.net/~kvn/8174879/webrev.hs/ 
> 
> Looks good to me.
> 
> /Magnus
>> 
>> Tested with RBT. 
>> 
>> Thanks, 
>> Vladimir 
> 

Reply via email to