As a short term solution then this looks okay to me.

-Alan


On 07/03/2017 08:51, Erik Joelsson wrote:
Hello,

The jmods for the imported javafx modules end up with _imported.marker files in them. The root cause of this issue is that we don't have a coherent naming scheme for our touch/marker files in the build. I have filed JDK-8176264 to address this properly. For the immediate problem I instead propose this simple patch to the jmod creation. I have verified that the jmods no longer contain any touch files from the build.

Bug: https://bugs.openjdk.java.net/browse/JDK-8176172

Patch:

diff -r 4d29ee32d926 make/CreateJmods.gmk
--- a/make/CreateJmods.gmk
+++ b/make/CreateJmods.gmk
@@ -139,7 +139,7 @@
             --os-arch $(OPENJDK_TARGET_CPU_LEGACY) \
             --os-version $(REQUIRED_OS_VERSION) \
             --module-path $(JMODS_DIR) \
- --exclude '**{_the.*,*.diz,*.debuginfo,*.dSYM/**,*.dSYM,*.pdb,*.map}' \ + --exclude '**{_the.*,_*.marker,*.diz,*.debuginfo,*.dSYM/**,*.dSYM,*.pdb,*.map}' \
         $(JMOD_FLAGS) $(JMODS_TEMPDIR)/$(notdir $@)
     $(MV) $(JMODS_TEMPDIR)/$(notdir $@) $@

/Erik


Reply via email to