Looks good to me as well. Tim
On 04/19/17 04:46, Erik Joelsson wrote:
Looks good. /Erik On 2017-04-19 13:42, Magnus Ihse Bursie wrote:The file src/java.base/macosx/native/launcher/Info-privileged.plist, which is used when building signed macos launcher binaries, contains this snippet: <key>CFBundleName</key> <string>OpenJDK 7 Command</string> I assume this has not been updated since JDK 7. I suggest removing the version number from the file completely. Approved for fixing in JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8178438 Patch inline: diff --git a/src/java.base/macosx/native/launcher/Info-privileged.plist b/src/java.base/macosx/native/launcher/Info-privileged.plist --- a/src/java.base/macosx/native/launcher/Info-privileged.plist +++ b/src/java.base/macosx/native/launcher/Info-privileged.plist @@ -7,7 +7,7 @@ <key>CFBundleInfoDictionaryVersion</key> <string>6.0</string> <key>CFBundleName</key> - <string>OpenJDK 7 Command</string> + <string>OpenJDK Command</string> <key>CFBundleShortVersionString</key> <string>1.0</string> <key>CFBundleVersion</key> /Magnus
