> On Apr 19, 2017, at 5:54 AM, Magnus Ihse Bursie
> <[email protected]> wrote:
>
> With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html is no
> longer included in the generated documentation. The information provided by
> that file should move to src/jdk.jdi/share/classes/module-info.java instead.
>
> I also took the liberty of removing a bunch of other overview.html files that
> are not included in the Javadoc anymore. They provided no real informational
> value, and what text they contained is already expressed similarly or better
> in the corresponding module-info.java files instead.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8178037
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8178037-fix-obsolete-overview-files/webrev.01
Moving the content from jdi-overview.html to module-info.java is the right
choice.
Nit: if you don’t mind, can you replace <code>…</code> with {@code …}
Otherwise, looks fine.
The following sentence reads a little strange to me that contains a couple of
“…”.
I just want to point it out and we should leave it as is.
36 * The JDI also provides explicit control over a virtual machine's
execution.
37 * The ability to suspend and resume threads, and to set breakpoints,
38 * watchpoints, ... Notification of exceptions, class loading, thread
39 * creation... The ability to inspect a suspended thread's state, local
40 * variables, stack backtrace…
Mandy
