Hello,

Looks good. For efficiency reasons, I would recommend the following change:

Assign $1_$2_OPTIONS using just = for lazy evaluation so that we only do the shell call if executing the recipe. Also remove it from VARDEPS because the contents of OPTIONS only depends on the source file anyway and the rule already depends on the source file.

/Erik


On 2017-04-28 21:52, Magnus Ihse Bursie wrote:
To cover the coming needs of the added markdown specifications, a more proper function for setting up markdown processing is needed.

The CSS file is intented as a first approach/placeholder. It needs to be updated later on.

Bug: https://bugs.openjdk.java.net/browse/JDK-8179453
WebRev: http://cr.openjdk.java.net/~ihse/JDK-8179453-add-process-markdown/webrev.01

/Magnus

Reply via email to