Nah, it's fine.
/Erik
On 2017-05-09 04:37, Magnus Ihse Bursie wrote:
On 2017-05-05 17:52, Erik Joelsson wrote:
What's the reason for adding the conditional around SetupCopyFiles in
Javadoc.gmk? The SetupCopyFiles macro should be safe to call with an
empty FILES list. It should evaluate to basically nothing in that case.
I don't think there's an explicit reason. The code evolved that way.
The previous version had a check for $(SPECS_$m), since SetupCopyFiles
does *not* cope with an empty SRC. (Trust me on this ;-))
However, the new foreach will take care of that, so $d will always be
specified. The current pattern also mimicks the call to
SetupProcessMarkdown further down. (Which, I believe, would not handle
an empty value on FILES. Which it perhaps should.)
If nothing else, it would probably save us a few clock cycles. :-)
Do you want me to remove it?
/Magnus
/Erik
On 2017-05-05 06:17, Magnus Ihse Bursie wrote:
The Security Standard Names document will be moved to a new
location, so all links needs to be updated. Also, a minor fix to the
build system was needed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8178278
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8178278-standard-names-spec-as-markdown/webrev.01
/Magnus
