Instead of adding more explicit excludes, I would recommend moving the
windows specific source files to:
jdk/src/java.desktop/windows/classes
That is the intended way of making sources platform specific.
If you still need to add the qualified export to jdk.jconsole, but just
for windows, you can achieve this by creating:
jdk/src/java.desktop/windows/classes/module-info.java.extra
With the following content (+copyright header):
opens com.sun.java.swing.plaf.windows to jdk.jconsole
/Erik
On 2017-05-17 12:49, Prasanta Sadhukhan wrote:
Yes, actually I am bit unsure of how to proceed with that. It is meant
to open internal java.desktop classes "only" to jdk.jconsole but now
afer this fix, these classes will only be available in windows
platform, so it should be a conditional "open" and I am not sure if
module-info.java allows conditional open.
Regards
Prasanta
On 5/17/2017 4:16 PM, Magnus Ihse Bursie wrote:
Build changes looks good. However in
src/java.desktop/share/classes/module-info.java you are trying to
check in commented-out code instead of removing it.
/Magnus
On 2017-05-17 12:31, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue whereby it is seen that
WindowsLookAndFeel classes are built for non-windows platform,
where it is not needed.
Proposed fix is to remove building these classes for non-windows
platform.
JPRT build is successful. Also, fixed the regression tests which
expects this classes to be available in non-unix platform.
Bug: https://bugs.openjdk.java.net/browse/JDK-6461834
webrev: http://cr.openjdk.java.net/~psadhukhan/6461834/00/
There are some closed regression test which will be taken care after
this in a separate crucible review.
Regards
Prasanta
