On 2017-05-19 16:47, Mandy Chung wrote:
On May 19, 2017, at 1:08 AM, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com>
wrote:
"Indirect exports" was a good term. I dropped the "Deps" part of the name and
it all became much clearer.
Here's an updated webrev:
http://cr.openjdk.java.net/~ihse/JDK-8180480-docs-should-use-requires-transitive/webrev.02
+ $1_INDIRECT_EXPORTS := $$(call FindTransitiveIndirectExportsForModules,
$$($1_MODULES))
Nit: “exported” term is for API but not for dependency.
s/$1_INDIRECT_EXPORTS/$1_TRANSITIVE_MODULES
s/FindTransitiveIndirectExportsForModules/FindTransitiveIndirectDepsForModules
Otherwise, looks good. No need for a new webrev:
Well, but that's not really just a "nit", is it? The problem here was
that "transitive deps" had been used in the names of our macros in a
different way than "requires transitive" from module-info.java implies,
and now we're just back in that confusion anyway.
Oh well. I'll settle for those names (but under some protest!) for jdk
9, and then we'll have to make sure we get a better naming scheme that
aligns all the way for jdk 10.
/Magnus
Mandy
