On 2017-05-19 22:48, Mandy Chung wrote:
This patch updates the build tool to generate an improved presentation of the module groupings. A sample page: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180717/docs/index.htmlWebrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180717/webrev.00/ Thanks Mandy
This does not really affect the build system, so if you want to push this, go ahead. However, I do have some opinions:
1) You are re-adding a lot of css rules. This will make it harder to align this page with an common overall look-and-feel using the shared css file.
2) I don't want to sound harsh, but, but is this really an improvement? I find this page almost as bad as the old "brick wall". :-( It's incomprehensible until you read the small print legend at the bottom.
Also, one of the first things I learned in my human-computer interaction classes was to *never* use color as the single discriminating feature. A large minority of the population is color-blind and cannot tell the difference between e.g. red and green, and it's especielly hard if it's like those low saturation colors that you've picked.
/Magnus
