Looks good to me as well.

/Erik


On 2017-07-12 16:58, Jan Lahoda wrote:
Hi,

The ct.sym building needs to read existing module-infos, to properly detect transitive dependencies. But the target does not depend on all module-infos being generated, which may in turn lead to problems with incomplete module graph.

So, the proposed patch is to add the dependency on all generated module-infos. javac should crash this way even in a presence of incomplete module graph, this will be fixed under a separate ticket.

The cause was found and patch is by Erik.

Bug: https://bugs.openjdk.java.net/browse/JDK-8181298
Webrev: http://cr.openjdk.java.net/~jlahoda/8181298/webrev.00/

Comments are welcome.

Thanks,
    Jan

Reply via email to