On 2017-08-31 08:25, David Holmes wrote:
On 31/08/2017 4:14 PM, Thomas Stüfe wrote:
Hi Adrian,
this looks fine. Thanks for taking on BSD (I'm a bit confused though, I
thought BSD is already buildable).
Thomas you beat me to it - on both counts! I too recall others
building for BSD.
BSD is buildable for jdk9 in the separate, hardly-maintained bsd-port
only. :-(
I posted a set of patches for jdk9 mainline for building jdk9 on BSD,
that was rejected. :( They ended up in the bsd-port, but this has not
been pushed upstream to the mainline, and the bsd port is only
sporadically updated from mainline.
Since those changes are either a) general cleanups that all platforms
should benefit from, or b) no-risk bsd-only changes, I'd really like to
see them go into the mainline build system. But for that to happen, we
apparently need to change some policy about accepting code for platforms
not tested by Oracle. :-(
The changes, btw, look good.
/Magnus
David
Best Regards, Thomas
On Wed, Aug 30, 2017 at 10:30 PM, John Paul Adrian Glaubitz <
[email protected]> wrote:
Hello!
I started working on fixing OpenJDK on BSD today and already ran into
the first issue which is the configure script being unable to find a
usable toolchain.
This happens because there are no valid toolchains defined for BSD in
common/autoconf/toolchain.m4. Since both clang and gcc are supported
on most BSD systems, this can be trivially resolved with:
diff -r 1147dee33745 common/autoconf/toolchain.m4
--- a/common/autoconf/toolchain.m4 Tue Aug 29 17:17:57 2017 +0200
+++ b/common/autoconf/toolchain.m4 Wed Aug 30 22:22:49 2017 +0200
@@ -42,6 +42,7 @@
VALID_TOOLCHAINS_macosx="gcc clang"
VALID_TOOLCHAINS_aix="xlc"
VALID_TOOLCHAINS_windows="microsoft"
+VALID_TOOLCHAINS_bsd="gcc clang"
# Toolchain descriptions
TOOLCHAIN_DESCRIPTION_clang="clang/LLVM"
Webrev can be found in [1].
Adrian
[1] http://cr.openjdk.java.net/~glaubitz/8187004/webrev.00/
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - [email protected]
`. `' Freie Universitaet Berlin - [email protected]
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
