Looks good to me.
/Erik
On 2017-09-27 11:29, Magnus Ihse Bursie wrote:
In
make/langtools/src/classes/build/tools/symbolgenerator/TransitiveDependencies.java,
javac gets called with a fixed command line. This includes the
arguments "-source 9 -target 9". While this was fine for
jdk9, in jdk10 this results in the following warning:
warning: [options] bootstrap class path not set in conjunction with
-source 1.9
I presume it is a mistake that this was not updated to -source 10
-target 10 for jdk10.
I have verified that the contents of ct.sym has not changed due to
this patch.
I have kept the -source/-target arguments for now, and postponed the
discussion to remove them to JDK-8188015.
Bug: https://bugs.openjdk.java.net/browse/JDK-8188013
Patch inline:
diff --git
a/make/langtools/src/classes/build/tools/symbolgenerator/TransitiveDependencies.java
b/make/langtools/src/classes/build/tools/symbolgenerator/TransitiveDependencies.java
---
a/make/langtools/src/classes/build/tools/symbolgenerator/TransitiveDependencies.java
+++
b/make/langtools/src/classes/build/tools/symbolgenerator/TransitiveDependencies.java
@@ -57,8 +57,8 @@
}
JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
- List<String> options = Arrays.asList("-source", "9",
- "-target", "9",
+ List<String> options = Arrays.asList("-source", "10",
+ "-target", "10",
"-proc:only",
"--system", "none",
"--module-source-path", args[0],
/Magnus
