In my recent change for JDK-8189095, I changed the quoting of all src and targets files in the install-macros from single to double. I did this in an early version of that patch to allow for the shell to match the ? wildcard. In the final version of the patch, I instead use explicit subst of ? to space so there is no need for the shell to expand wildcards. This makes the change of quotes unnecessary.

Worse is that changing to double quotes has now made the shell expand strings like "$1" in file names, which typically occurs with anonymous inner classes in Java. This causes both intermittent build errors as well as prevents files with $ in them from being copied.

This patch restores the double quotes to single quotes.

Bug: https://bugs.openjdk.java.net/browse/JDK-8189324

Webrev: http://cr.openjdk.java.net/~erikj/8189324/webrev.01/

/Erik

Reply via email to