On 2017-10-30 08:39, Artem Smotrakov wrote:
cc'ing [email protected] as David suggested.
Artem
On 10/27/2017 11:02 PM, Artem Smotrakov wrote:
Hello,
Please review the following patch which adds support for
AddressSanitizer.
AddressSanitizer is a runtime memory error detector which looks for
various memory corruption issues and leaks.
Please refer to [1] for details. AddressSanitizer is available in gcc
4.8+ and clang 3.1+
The patch below introduces --enable-asan parameter for the configure
script which enables AddressSanitizer.
Bug: https://bugs.openjdk.java.net/browse/JDK-8189800
Webrev: http://cr.openjdk.java.net/~asmotrak/8189800/webrev.00/
spec.gmk.in should only have export for variables that needs to be
exported in the environment for executing binaries, that is ASAN_OPTIONS
and LD_LIBRARY_PATH, not ASAN_ENABLED or DEVKIT_LIB_DIR.
I'm also a bit curious about the addition of of DEVKIT_LIB_DIR. Would
you care to elaborate your thinking?
Otherwise it looks good.
/Magnus
[1] https://github.com/google/sanitizers/wiki/AddressSanitizer
Artem
