On 5/12/2017 7:30 PM, Magnus Ihse Bursie wrote:
On 2017-12-05 10:21, David Holmes wrote:
Hi Magnus,
On 5/12/2017 7:12 PM, Magnus Ihse Bursie wrote:
JDK-8190484 modifies how the copy step of the build process works.
Unfortunately, this broke building on Windows in jdk.accessibility.
Since JDK-8190484 was pushed to jdk/hs, I intend to push this to
jdk/hs as well.
Bug: https://bugs.openjdk.java.net/browse/JDK-8193045
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8193045-fix-broken-copy-includes/webrev.01
This seems reasonable.
Thanks. Do I need a second reviewer to push this?
I don't think so - it's a build issue, and I've verified the fix myself
in a JPRT run. :)
You are skipping empty directories - which is what the build failures
was choking on.
Actually, the build choked on that $(wildcard) found a directory, which
then was sent to cp in SetupCopyFiles, but cp didn't want to copy a
directory since it was not called (correctly) with -r.
Okay I was imprecise in my description :)
Thanks,
David
On top of that there was also an aesthetic issue with error messages
printed from find when looking in non-existing directories. It was ugly
but didn't break the build.
/Magnus
Thanks,
David
/Magnus
