Thank you for the review Christian!  I have gone forward and created the RFE at https://bugs.openjdk.java.net/browse/JDK-8198652.
Lois

On 2/23/2018 3:54 PM, Christian Tornqvist wrote:
Forgot to say that the webrev looks good!

On Feb 23, 2018, at 3:53 PM, Christian Tornqvist 
<christian.tornqv...@oracle.com> wrote:

Sounds like a good plan :)

Thanks,
Christian

On Feb 23, 2018, at 3:22 PM, Lois Foltan <lois.fol...@oracle.com> wrote:

On 2/23/2018 3:18 PM, Christian Tornqvist wrote:

Hi Lois,

Why do we link jvm.dll with -base?
Hi Christian,
It is not clear to me why we do, so I was going to follow up with an RFE to 
investigate & suggest the removal of -base if unnecessary.
Lois

Thanks,
Christian

On Feb 23, 2018, at 3:11 PM, Lois Foltan <lois.fol...@oracle.com> wrote:

Please review this fix to ignore linker warning (LNK4281).  This is a new linker warning 
generated by VS2017 v15.5 to "to point out any 64-bit image specified to link with a 
lower than 4GB base address doesn't get best ASLR optimization". The Hotspot jvm.dll 
is specifically linked with -base:0x8000000.  As recommended by 
https://developercommunity.visualstudio.com/content/problem/160970/upgrading-from-154-to-155-throw-lnk4281-warning.html,
 this linker warning can be suppressed with -ignore.

open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8198640/webrev/
bug link https://bugs.openjdk.java.net/browse/JDK-8198640

Testing (hs-tier1-3 & jdk-tier1-3) in progress

Thanks,
Lois



Reply via email to