On 9/03/2018 11:00 PM, Archana Nogriya wrote:
Thanks David, Erik for your response.

JVMTI is a generic JVM debug specification, J9 has it's own version of it.

Not quite sure what you mean there. The JVM TI specification is the JVM TI specification:

https://docs.oracle.com/javase/9/docs/specs/jvmti.html

Implementations of it can vary and support, or not, different parts, but the spec is the spec.

David
-----

As per J9 requirement, we might want to be able to do is filter out the above from JDK_SPECS_TARGETS, and add J9 one if it exists currently Docs.gmk I do not see .post custom extension point and to use our own version we need a way of doing it.




Thanks and Regards
Archana Nogriya
IBM Java Runtime, Open Java Developer
IBM Hursley
Tel: Internal - 247073, External - +44 (0) 1962 81 7073
Office Mobile: 07500095480
Email: archana.nogr...@uk.ibm.com



From: David Holmes <david.hol...@oracle.com>
To: Archana Nogriya <archana.nogr...@uk.ibm.com>, build-dev@openjdk.java.net
Date: 08/03/2018 21:26
Subject: Re: Contribution to make/Docs.gmk
------------------------------------------------------------------------



Hi,

On 9/03/2018 12:51 AM, Archana Nogriya wrote:
Hi,

In "make/Docs.gmk" We have found 2 issues which required  to be fixed in
OpenJDK,

1)
-JDK_MODULES := $(sort $(DOCS_MODULES))
+JDK_MODULES := $(sort $(filter-out $(MODULES_FILTER), $(DOCS_MODULES)))

==> This is an OpenJDK bug as this should be filtering out the
MODULES_FILTER modules... hence required contribute to OpenJDK...

2)
-JVMTI_HTML :=
$(HOTSPOT_OUTPUTDIR)/variant-$(JVM_VARIANT_MAIN)/gensrc/jvmtifiles/jvmti.html
-$(eval $(call SetupCopyFiles, COPY_JVMTI_HTML, \

         FILES := $(JVMTI_HTML), \
         DEST := $(DOCS_OUTPUTDIR)/specs,
-))
-JDK_SPECS_TARGETS += $(COPY_JVMTI_HTML)
+#JVMTI_HTML :=
$(HOTSPOT_OUTPUTDIR)/variant-$(JVM_VARIANT_MAIN)/gensrc/jvmtifiles/jvmti.html
+#$(eval $(call SetupCopyFiles, COPY_JVMTI_HTML,
+# FILES := $(JVMTI_HTML),
+# DEST := $(DOCS_OUTPUTDIR)/specs,
+#))
+#JDK_SPECS_TARGETS += $(COPY_JVMTI_HTML)

==> We need to be able to unset/filterout the $(COPY_JVMTI_HTML)  value in
JDK_SPECS_TARGETS, if we get a "post" CustomIncludeExtension  added at the
end of Docs.gmk we can then the unset/filterout $(COPY_JVMTI_HTML)  value.
Hence OpenJDK contribution required.

Why do you think the JVM TI specification should not be part of the
JDK_SPECS_TARGET? Is this just because it is in the hotspot part of the
source tree?

David

Please would like to hear other views on this fix and if we have better
way of dealing this.


Thanks and Regards
Archana Nogriya
IBM Java Runtime, Open Java Developer
IBM Hursley
Tel: Internal - 247073, External - +44 (0) 1962 81 7073
Office Mobile: 07500095480
Email: archana.nogr...@uk.ibm.com

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with  number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire  PO6 3AU






Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Reply via email to