On 2018-03-23 06:22, David Holmes wrote:
Hi Thomas,
On 23/03/2018 2:55 PM, Thomas Stüfe wrote:
Hi David,
would it not be pragmatic to accept Ao's patch - it looks fine to me
- since it certainly would not make matters worse. And let Magnus
follow up with a cleanup change later?
Well I hope Magnus's change is forthcoming.
It might be some time still. I'm working on a complete overhaul of all
CFLAGS and LDFLAGS, where this is a part of that picture, but I was not
planning on addressing just this thing urgently.
So, I think this patch will do for now. It solves the immediate problem
for MIPS, and I can come back and make a cleaner solution later on.
AFAICS it's as easy to write this only for x86 as it is to exclude it
for non x86. Honestly I don't know why the Aarch64 patch was done the
way it was - there must be some subtlety here that I'm not aware of.
I think it was just the smallest patch that worked for the aarch64
platform. I didn't spend time arguing about the fix, since it is
supposed to be short-lived anyway.
/Magnus
