Hi Matthias, thanks for fixing this!
Patch works and looks ok. Best Regards, Thomas On Mon, Mar 26, 2018 at 4:55 PM, Baesken, Matthias <matthias.baes...@sap.com > wrote: > Hello, after recent adjustments of src/hotspot/share/trace/ > traceEventClasses.xsl > in jdk/hs ( see 8196337: Add commit methods that take all event > properties as argument ) the AIX build fails. > > The xlC compiler is not happy with > > using TraceEvent::commit; > > in traceEventClasses.xsl (looks like correct C++ but xlc 12.1 refuses to > compile ). > Error messages : > > /nightly/output-jdk-hs/hotspot/variant-server/gensrc/ > tracefiles/traceEventClasses.hpp", line 226.9: 1540-1113 (S) The class > template name "TraceEvent" must be followed by a < in this context. > > > Bug : > > https://bugs.openjdk.java.net/browse/JDK-8200246 > > Adding the template parameter to TraceEvent makes xlc happy too. > > http://cr.openjdk.java.net/~mbaesken/webrevs/8200246/ > > > Are you fine with this change ? > > Best regards, Matthias > >
