If I understand the fix correctly, it will resolve the build issue. However, libjsig will not work, since we will not export any symbols at all.
For this to work, we also need to filter out the fvisibility/xldscope flags from CFLAGS. I apologize for the mess I created. :-( /Magnus > 29 mars 2018 kl. 16:18 skrev Erik Joelsson <erik.joels...@oracle.com>: > > The removal of mapfiles didn't completely work out. On Solaris we now get the > following build error: > > "/localhome/erik/jdk/open/src/java.base/solaris/native/libjsig/jsig.c", line > 181: error: redeclaration must have the same or more restrictive linker > scoping: signal > "/localhome/erik/jdk/open/src/java.base/solaris/native/libjsig/jsig.c", line > 186: error: redeclaration must have the same or more restrictive linker > scoping: sigset > "/localhome/erik/jdk/open/src/java.base/solaris/native/libjsig/jsig.c", line > 203: error: redeclaration must have the same or more restrictive linker > scoping: sigaction > cc: acomp failed for > /localhome/erik/jdk/open/src/java.base/solaris/native/libjsig/jsig.c > > As a quick fix I have reverted the mapfile removal for libjsig on Solaris. > With the following changes the build works again. Hopefully Magnus will be > able to figure out the proper fix next week (after the Swedish Easter > holidays). > > Webrev: http://cr.openjdk.java.net/~erikj/8200409/webrev.01/index.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8200409 > > Please note that I'm on vacation today and will soon get in a car for a long > drive. I urge someone else to pick this up and push it as soon as it is > reviewed (or find a better solution) so that a promoted build can be produced > this week. > > /Erik >
