> On Apr 4, 2018, at 3:59 PM, Magnus Ihse Bursie > <magnus.ihse.bur...@oracle.com> wrote: > > Hi Max, > > On 2018-04-04 04:19, Weijun Wang wrote: >> Hi All >> >> Please take a review at >> >> http://cr.openjdk.java.net/~weijun/8200468/webrev.00/ > > The indentation in Lib-java.security.jgss.gmk has gone wrong. The lines in > the "$(eval $(call SetupJdkLibrary" stanza should still be indented four > spaces. See the makefile style guide: > http://openjdk.java.net/groups/build/doc/code-conventions.html
So this is for "2. If a line must be broken, use four spaces for indentation". Right? > > Please always cc build-dev when making changes to makefiles. I'll remember it. Thanks Max > > /Magnus > > > > > >> >> Like in *nix, native GSS-API bridge is turned on by setting >> -Dsun.security.jgss.native=true. Please note there is no default native >> GSS-API library on Windows and you need to supply your own, like this: >> >> java -Dsun.security.jgss.native=true >> -Dsun.security.jgss.lib=/path/to/gssapi64.dll App ... >> >> You can manually test the change with >> >> jtreg -Dnative.krb5.libs=j=,n=/path/to/gssapi64.dll >> test/jdk/sun/security/krb5/auto/BasicProc.java >> >> Thanks >> Max >> >> p.s. You can get a gssapi64.dll from >> https://web.mit.edu/KERBEROS/kfw-4.1/kfw-4.1.html. >
