On 2018-04-10 13:25, Severin Gehwolf wrote:
On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote:
I'm ok with this solution for now.
Thanks for the review!
Could you please reduce the indentation on line 652. In the build system
we like 4 spaces for continuation indent 
Done. New webrev at:
It's not nice, but there's no other way to do it right now. Approved.
(I'm working on getting to the point were I can address this in a better
Could someone from awt-dev have a look at this too? Thanks!
On 2018-04-09 06:39, Severin Gehwolf wrote:
Could somebody please review this build fix for libfontmanager.so. The
issue for us is that with some LDFLAGS the build breaks as described in
bug JDK-8196218. However, we cannot link to a providing library at
build-time since we don't know which one it should be: libawt_headless
or libawt_xawt. That has to happen at runtime. The proposed fix filters
out relevant linker flags when libfontmanager is being built. More
details are in the bug.
Testing: I've run this through submit and got the following results.
SwingSet2 works fine for me on F27. I'm currently running some more
tests on RHEL 7.
Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED.
0 Failed Tests
Mach5 Tasks Results Summary
debug-31 SetupFailedException in setup...profile run-test-prebuilt' ,
return value: 10
Not sure what this test failure means. Could somebody at Oracle shed
some light on this?