Looks good to me.
/Magnus
On 2018-04-11 17:38, Kevin Walls wrote:
Hi,
I'd like to request review of this backport from 9 to 8u:
8035495: Improvements in autoconf integration
JBS: https://bugs.openjdk.java.net/browse/JDK-8035495
9 changeset:
URL: http://hg.openjdk.java.net/jdk9/dev/rev/6e29cd9ac2b4
User: ihse
Date: 2014-02-24 12:31:07 +0000
9 review thread:
http://mail.openjdk.java.net/pipermail/build-dev/2014-February/011963.html
This mostly imports to 8u, but requires some manual editing as one
chunk in each of common/autoconf/autogen.sh,
common/autoconf/basics.m4, and common/autoconf/configure didn't
import, plus regenerating generated-configure.sh.
There was a follow-on bug which I'll apply at the same time, which was:
8035825: Warn instead of fail when calling the configure wrapper directly
JBS: https://bugs.openjdk.java.net/browse/JDK-8035825
9 changeset:
URL: http://hg.openjdk.java.net/jdk9/dev/rev/e7872d8abd12
User: ihse
Date: 2014-02-27 08:20:50 +0000
9 review:
http://mail.openjdk.java.net/pipermail/build-dev/2014-February/011988.html
This required some manual editing just for the change at the start of
common/autoconf/configure.
8u webrev with them both applied:
http://cr.openjdk.java.net/~kevinw/8035495/webrev.00/
(8035496 is committed in there, 8035825 is not)
Many thanks!
Kevin
