> 12 apr. 2018 kl. 17:38 skrev Erik Joelsson <erik.joels...@oracle.com>: > > Looks good. Especially adding those # header lines in basics.m4!
Thanks! I'm actually thinking about splitting out a utils.m4 from basics.m4, for these kinds of helper functions. Sounds ok? > > I guess a future followup now is to get rid of the individual enable/disable > args that are now redundant. Yes, that is the goal. /Magnus > > /Erik > > >> On 2018-04-12 04:39, Magnus Ihse Bursie wrote: >> It is currently easy to add new JVM features to the JVM build, but it is not >> possible to remove features. >> >> With this change, features can be both added or removed from the default >> set. They are added using --with-jvm-features=f1,f2 and removed using >> --with-jvm-features=-f1,-f2. The syntax can be combined, so >> --with-jvm-features=dtrace,-nmt will enable dtrace but disable native memory >> tracking. >> >> I also included some additional code cleanup and fixes, such as printing the >> JVM feature set at the summary. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8201483 >> WebRev: >> http://cr.openjdk.java.net/~ihse/JDK-8201483-disable-JVM-features/webrev.01 >> >
