Hi Matthias,
Your change looks good to me. It might make sense to also remove the
following lines from:
src/jdk.hotspot.agent/linux/native/libsaproc/libproc.h
78 #if defined(s390x)
79 #include <asm/ptrace.h>
80 #endif
I am not sure if the following files are required either:
src/hotspot/cpu/s390/vmStructs_s390.hpp
src/hotspot/os_cpu/linux_s390/vmStructs_linux_s390.hpp
Thanks,
Jini (Not a Reviewer).
On 4/23/2018 5:31 PM, Baesken, Matthias wrote:
Hello, as far as I know the serviceability agent is not supported
on linux s390x .
However (unlike on aix where it is not supported as well) ,
INCLUDE_SA=false is not set in the central configure m4 files .
Should we set it ( suggested diff below) ?
Best regards, Matthias
hg diff
diff -r fcd5df7aa235 make/autoconf/jdk-options.m4
--- a/make/autoconf/jdk-options.m4 Wed Apr 18 11:19:32 2018 +0200
+++ b/make/autoconf/jdk-options.m4 Mon Apr 23 13:46:17 2018 +0200
@@ -238,6 +238,9 @@
if test "x$OPENJDK_TARGET_OS" = xaix ; then
INCLUDE_SA=false
fi
+ if test "x$OPENJDK_TARGET_CPU" = xs390x ; then
+ INCLUDE_SA=false
+ fi
AC_SUBST(INCLUDE_SA)
# Compress jars
Best regards, Matthias
